lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 12 Oct 2014 14:48:12 +0300 From: "Michael S. Tsirkin" <mst@...hat.com> To: linux-kernel@...r.kernel.org Cc: Rusty Russell <rusty@...tcorp.com.au>, virtualization@...ts.linux-foundation.org, linux-scsi@...r.kernel.org, linux-s390@...r.kernel.org, v9fs-developer@...ts.sourceforge.net, netdev@...r.kernel.org, kvm@...r.kernel.org, Amit Shah <amit.shah@...hat.com>, Cornelia Huck <cornelia.huck@...ibm.com>, Christian Borntraeger <borntraeger@...ibm.com>, "David S. Miller" <davem@...emloft.net>, Paolo Bonzini <pbonzini@...hat.com> Subject: [PATCH v3 20/25] virtio_net: enable VQs early on restore virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after restore returns, virtio net violated this rule by using receive VQs within restore. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by: Michael S. Tsirkin <mst@...hat.com> Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com> --- drivers/net/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 3551417..6b6e136 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1912,6 +1912,8 @@ static int virtnet_restore(struct virtio_device *vdev) if (err) return err; + virtio_enable_vqs_early(vdev); + if (netif_running(vi->dev)) { for (i = 0; i < vi->curr_queue_pairs; i++) if (!try_fill_recv(&vi->rq[i], GFP_KERNEL)) -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists