linux-kernel - linux-next: build failure after merge of the akpm-current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Oct 2014 15:56:57 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Johannes Weiner <hannes@...xchg.org>
Subject: linux-next: build failure after merge of the akpm-current tree

Hi Andrew,

After merging the akpm tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from mm/memcontrol.c:28:0:
include/linux/page_counter.h: In function 'page_counter_init':
include/linux/page_counter.h:19:27: error: 'LONG_MAX' undeclared (first use in this function)
 #define PAGE_COUNTER_MAX (LONG_MAX / PAGE_SIZE)
                           ^
include/linux/page_counter.h:26:19: note: in expansion of macro 'PAGE_COUNTER_MAX'
  counter->limit = PAGE_COUNTER_MAX;
                   ^
include/linux/page_counter.h:19:27: note: each undeclared identifier is reported only once for each function it appears in
 #define PAGE_COUNTER_MAX (LONG_MAX / PAGE_SIZE)
                           ^
include/linux/page_counter.h:26:19: note: in expansion of macro 'PAGE_COUNTER_MAX'
  counter->limit = PAGE_COUNTER_MAX;
                   ^
include/linux/page_counter.h:19:38: error: 'PAGE_SIZE' undeclared (first use in this function)
 #define PAGE_COUNTER_MAX (LONG_MAX / PAGE_SIZE)
                                      ^
include/linux/page_counter.h:26:19: note: in expansion of macro 'PAGE_COUNTER_MAX'
  counter->limit = PAGE_COUNTER_MAX;
                   ^
In file included from mm/page_counter.c:7:0:
include/linux/page_counter.h: In function 'page_counter_init':
include/linux/page_counter.h:19:27: error: 'LONG_MAX' undeclared (first use in this function)
 #define PAGE_COUNTER_MAX (LONG_MAX / PAGE_SIZE)
                           ^
include/linux/page_counter.h:26:19: note: in expansion of macro 'PAGE_COUNTER_MAX'
  counter->limit = PAGE_COUNTER_MAX;
                   ^
include/linux/page_counter.h:19:27: note: each undeclared identifier is reported only once for each function it appears in
 #define PAGE_COUNTER_MAX (LONG_MAX / PAGE_SIZE)
                           ^
include/linux/page_counter.h:26:19: note: in expansion of macro 'PAGE_COUNTER_MAX'
  counter->limit = PAGE_COUNTER_MAX;
                   ^
include/linux/page_counter.h:19:38: error: 'PAGE_SIZE' undeclared (first use in this function)
 #define PAGE_COUNTER_MAX (LONG_MAX / PAGE_SIZE)
                                      ^
include/linux/page_counter.h:26:19: note: in expansion of macro 'PAGE_COUNTER_MAX'
  counter->limit = PAGE_COUNTER_MAX;
                   ^

Caused by commit 36a1bfb2a772 ("mm: memcontrol: lockless page
counters").  See Rule 1 in Documentation/SubmitChecklist.

I have added the following patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Thu, 16 Oct 2014 15:49:08 +1100
Subject: [PATCH] mm: memcontrol: add includes for page_counter.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 include/linux/page_counter.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/page_counter.h b/include/linux/page_counter.h
index a878ef61d073..785640e4efec 100644
--- a/include/linux/page_counter.h
+++ b/include/linux/page_counter.h
@@ -2,6 +2,9 @@
 #define _LINUX_PAGE_COUNTER_H
 
 #include <linux/atomic.h>
+#include <linux/kernel.h>
+
+#include <asm/page.h>
 
 struct page_counter {
 	atomic_long_t count;
-- 
2.1.1


-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)