linux-kernel - Re: [PATCH v5 00/12] Add ACPI _DSD and unified device properties support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Oct 2014 14:22:48 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Aaron Lu <aaron.lu@...el.com>, devicetree@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Bryan Wu <cooloney@...il.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5 00/12] Add ACPI _DSD and unified device properties support

On Friday, October 17, 2014 02:01:33 PM Rafael J. Wysocki wrote:
> Hi Everyone,
> 
> Hving had a couple of chats with Grant and Arnd during LinuxCon EU/LPC, we
> now have version 5 taking all feedback into account (hopefully).
> 
> Changes have been made to patch [02/12] and to patches [09-12/12], although
> in patches [10-12/12] they are fairly minor.  I have retained the Greg's
> ACK on patch [02/12], because it is essentially the same that have been
> posted aleady and ACKed by him (Greg, please let me know if I shouldn't
> do that) and all the ACKs on the remaining patches except for patch [09/12]
> which is substantially different.  Still, if reviewers think that their
> ACKs don't apply any more, please let me know and I'll remove them.
> 
> Patch [02/12] now contains helper functions for all proprerty data types
> that can be accessed which call the existing of_ functions, because Grant
> preferred that.
> 
> Patch [09/12] introduces quite a new concept, which is the struct fwnode_handle
> structure containing one field (type) and embedded in struct device_node
> (type==FWNODE_OF) and struct acpi_device (type==FWNODE_ACPI).  In short, if
> we are passed a struct fwnode_handle pointer, we can get from it to the
> appropriate device node pointer (either struct acpi_device or struct device_node)
> using container_of() after we've checked the type.  This is needed for the code
> that needs to access child nodes of a device in case when they don't have
> struct device representations (whatever the reason).  This has been suggested
> by Grant and pretty much everyone involved agrees that it's better that the
> alternatives presented so far.

While at it, many thanks to Mika for testing the patches on MinnowBoard 1 and
MinnowBoard Max and fixing build problems with them while we've been having
fun at the conferences!  I wouldn't have been able to prepare the patchset
for posting without that work.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/