linux-kernel - Re: [PATCH] mfd: max77693: Fix a truncate warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2014 12:38:11 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max77693: Fix a truncate warning

On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote:

> Fix warning on x86_64, make allyesconfig:
> 
> drivers/mfd/max77693.c: In function ‘max77693_i2c_probe’:
> drivers/mfd/max77693.c:259:5: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>      SRC_IRQ_ALL, ~SRC_IRQ_ALL);
>      ^

Applied and fixed up into:

  mfd: max77693: Fix always masked MUIC interrupts

Thanks.

> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
>  drivers/mfd/max77693.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 4e4e6a1a6301..0c9ec6bae022 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -256,7 +256,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
>  	/* Unmask interrupts from all blocks in interrupt source register */
>  	ret = regmap_update_bits(max77693->regmap,
>  				MAX77693_PMIC_REG_INTSRC_MASK,
> -				SRC_IRQ_ALL, ~SRC_IRQ_ALL);
> +				SRC_IRQ_ALL, (unsigned int)~SRC_IRQ_ALL);
>  	if (ret < 0) {
>  		dev_err(max77693->dev,
>  			"Could not unmask interrupts in INTSRC: %d\n",

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/