linux-kernel - Re: [PATCH v2 23/47] power/reset: gpio-poweroff: Register with kernel poweroff handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2014 23:32:46 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v2 23/47] power/reset: gpio-poweroff: Register with
 kernel poweroff handler

Hi,

On Mon, Oct 20, 2014 at 09:12:39PM -0700, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with low priority to reflect that the original code
> only sets pm_power_off if it was not already set.
> 
> Other changes:
> 
> Drop note that there can not be an additional instance of this driver.
> The original reason no longer applies, it should be obvious that there
> can only be one instance of the driver if static variables are used to
> reflect its state, and support for multiple instances can now be added
> easily if needed by avoiding static variables.
> 
> Do not create an error message if another poweroff handler has already
> been registered. This is perfectly normal and acceptable.
> 
> Drop remove function since it is no longer needed.
> 
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Acked-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-By: Sebastian Reichel <sre@...nel.org>

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)