linux-kernel - Re: [RFC PATCH] coredump: fix incomplete core file created when dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Oct 2014 18:39:34 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Victor Kamensky <victor.kamensky@...aro.org>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kees Cook <keescook@...omium.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] coredump: fix incomplete core file created when
	dump_skip was used last

On 10/22, Victor Kamensky wrote:
>
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -664,6 +664,14 @@ void do_coredump(const siginfo_t *siginfo)
>         if (!dump_interrupted()) {
>                 file_start_write(cprm.file);
>                 core_dumped = binfmt->core_dump(&cprm);
> +               /*
> +                * If last operation was dump_skip with llseek, we need to
> +                * truncate file up to f_pos to match expected size.
> +                */
> +               if (!ispipe &&
> +                   (cprm.file->f_pos > i_size_read(file_inode(cprm.file))))
> +                       do_truncate(cprm.file->f_path.dentry,
> +                                   cprm.file->f_pos, 0, cprm.file);
>                 file_end_write(cprm.file);
>         }
>         if (ispipe && core_pipe_limit)
>
> May I use your name with Suggested-by tag?

Sure, thanks ;)

I'd suggest to add a simple helper, but I won't insist. And perhaps the
caller can also check "core_dumped" along with !ispipe, but this is
purely cosmetic.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/