linux-kernel - Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Oct 2014 16:54:23 +0900
From:	Gyungoh Yoo <gyungoh@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org, jg1.han@...sung.com,
	cooloney@...il.com, lgirdwood@...il.com, jack.yoo@...worksinc.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	shawn.guo@...escale.com, treding@...dia.com,
	florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
	andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible
 string for device binding

On Thu, Oct 23, 2014 at 02:01:03PM +0100, Mark Brown wrote:
> On Thu, Oct 23, 2014 at 12:14:43PM +0900, Gyungoh Yoo wrote:
> 
> > So, what do you think about DT like below?
> 
> > sky81452@2c {
> > 	compatible = "skyworks,sky81452";
> > 	reg = <0x2c>;
> > 
> > 	backlight {
> > 		compatible = "skyworks,sky81452-backlight";
> > 		name = "pwm-backlight";
> > 		enable = <0x3F>;
> > 		ignore-pwm;
> > 	};
> > 
> > 	regulator {
> > 		compatible = "skyworks,sky81452-regulator";
> 
> Yes, this is good but I still feel that the above compatible is
> redundant and shouildn't be there.

I see. I will remove compatible string at the next resubmit.

> 
> > 		lout@0 {
> > 			regulator-name = "LOUT";
> > 			regulator-min-microvolt = <4500000>;
> > 			regulator-max-microvolt = <8000000>;
> > 		};
> > 	};
> > };


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/