linux-kernel - Re: [PATCH] pinctrl: at91: fix compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Oct 2014 22:10:19 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Linus Walleij <linus.walleij@...aro.org>
CC:	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pinctrl: at91: fix compilation

Hello.

On 10/28/2014 09:58 PM, Alexandre Belloni wrote:

> Add macros introduced by 4334ac2db2be9e278c95fd15260c1f49f698ffc5 that

    Please also specify that commit's summary line in parens.

> were missed when copying the header.

> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
>   drivers/pinctrl/pinctrl-at91.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.h b/drivers/pinctrl/pinctrl-at91.h
> index c837c66ea360..79b957f1dfa2 100644
> --- a/drivers/pinctrl/pinctrl-at91.h
> +++ b/drivers/pinctrl/pinctrl-at91.h
> @@ -63,4 +63,10 @@
>   #define PIO_FRLHSR	0xd8	/* Fall/Rise - Low/High Status Register */
>   #define PIO_SCHMITT	0x100	/* Schmitt Trigger Register */
>
> +#define SAMA5D3_PIO_DRIVER1		0x118  /*PIO Driver 1 register offset*/
> +#define SAMA5D3_PIO_DRIVER2		0x11C  /*PIO Driver 2 register offset*/
> +
> +#define AT91SAM9X5_PIO_DRIVER1	0x114  /*PIO Driver 1 register offset*/
> +#define AT91SAM9X5_PIO_DRIVER2	0x118  /*PIO Driver 2 register offset*/

    Please add spaces after /* and before */.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/