linux-kernel - Re: [PATCH] Add ltc3562 voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Oct 2014 12:30:05 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add ltc3562 voltage regulator driver

On Wed, Oct 29, 2014 at 09:16:00AM +0100, Mike Looijmans wrote:

> +	if (!status->voltage_set) {
> +		if (of_property_read_u32(dev->dev.of_node,
> +			"ltc3562-default-voltage", &v_default) == 0) {

A couple of problems here:

 - This contains DT code but no DT bindings documentation; the binding
   documentation is mandatory for any new bindings.
 - It's not obvious why a "default voltage" property would be device
   specific - what is this for and why is it being added in an
   individual device driver?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)