linux-kernel - Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Nov 2014 00:55:42 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	gyungoh@...il.com, sameo@...ux.intel.com, lee.jones@...aro.org,
	jg1.han@...sung.com, cooloney@...il.com, lgirdwood@...il.com,
	jack.yoo@...worksinc.com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, grant.likely@...aro.org,
	robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	shawn.guo@...escale.com, treding@...dia.com,
	florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
	andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible
 string for device binding

On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote:
> On Fri, 2014-10-31 at 16:44 +0000, Mark Brown wrote:

> > it doesn't seem obviously related to the driver
> > change and should probably be in the same patch as the MFD symbol rename
> > for bisetion.

> I don't think there will be bisection problems (in mainline). Currently
> this driver depends on SKY81452. But that symbol doesn't exist. Only
> after both 1/8 and this patch will this driver become buildable, for the
> first time. So it's not that this driver was buildable, became
> unbuildable in 1/8 and buildable again in this patch.

> (I don't think it's much of a problem that the regulator driver got
> merged, in v3.18-rc1, before the mfd driver on which it depends.
> Avoiding that temporarily problem appears to be more trouble than it's
> worth.)

The symbol rename should not be randomly shoved in with another patch,
and if the MFD still hasn't been merged then it probably makes sense to
do the rename as part of merging the MFD so it's clear what's going on.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)