linux-kernel - Re: [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 Nov 2014 15:32:54 -0500
From:	Milosz Tanski <milosz@...in.com>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-aio@...ck.org" <linux-aio@...ck.org>,
	Mel Gorman <mgorman@...e.de>,
	Volker Lendecke <Volker.Lendecke@...net.de>,
	Tejun Heo <tj@...nel.org>, "Theodore Ts'o" <tytso@....edu>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linux API <linux-api@...r.kernel.org>,
	Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2

I have fixed this in the version I'm going to be resubmitting today.

- Milosz

On Fri, Oct 24, 2014 at 11:46 AM, Jeff Moyer <jmoyer@...hat.com> wrote:
> Milosz Tanski <milosz@...in.com> writes:
>
>> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
>> index 22749c1..10f8883 100644
>> --- a/include/uapi/asm-generic/unistd.h
>> +++ b/include/uapi/asm-generic/unistd.h
>> @@ -213,6 +213,10 @@ __SC_COMP(__NR_pwrite64, sys_pwrite64, compat_sys_pwrite64)
>>  __SC_COMP(__NR_preadv, sys_preadv, compat_sys_preadv)
>>  #define __NR_pwritev 70
>>  __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev)
>> +#define __NR_preadv2 281
>> +__SC_COMP(__NR_preadv2, sys_preadv2)
>> +#define __NR_pwritev2 282
>> +__SC_COMP(__NR_pwritev2, sys_pwritev2)
>
> This looks odd.  First, __SC_COMP takes 3 arguments.  Second, you are
> going to need to implement compat wrappers for the new system calls.
>
> Cheers,
> Jeff



-- 
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@...in.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/