linux-kernel - Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 06 Nov 2014 10:18:45 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Tanya Brokhman <tlinder@...eaurora.org>
Cc:	hujianyang <hujianyang@...wei.com>,
	ezequiel.garcia@...e-electrons.com,
	Richard Weinberger <richard@....at>,
	open list <linux-kernel@...r.kernel.org>,
	linux-mtd@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging
 capabilities

On Sun, 2014-11-02 at 19:14 +0200, Tanya Brokhman wrote:
> >> +    ubi_err(ubi, "self-check failed for PEB %d", pnum);
> >> +    ubi_msg(ubi, "hex dump of the %d-%d region",
> >> +             offset, offset + len);
> >>      print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1, buf,
> len, 1);
> >>      err = -EINVAL;
> >>   error:
> >
> > Artem, I know you have tried to align the message code in different
> lines, maybe
> > you can check if you lose this one.
> >
> 
> hmmm... not sure I understand what is wrong here....

It is more of a nit-pick, but we try to be consistent. Here is how we
align split messages:

  ubi_msg(ubi, "blah",
          XYZ)

and not

  ubi_msg(ubi, "blah",
            XYZ)

So we first use few tabs, and then some spaces to align. You use just
tabs. Sometimes the second line is aligned, sometimes it goes a bit
further.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/