[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2014 10:29:32 +0000
From: David Vrabel <david.vrabel@...rix.com>
To: Juergen Gross <jgross@...e.com>, <linux-kernel@...r.kernel.org>,
<xen-devel@...ts.xensource.com>, <konrad.wilk@...cle.com>,
<david.vrabel@...rix.com>, <boris.ostrovsky@...cle.com>,
<x86@...nel.org>, <tglx@...utronix.de>, <mingo@...hat.com>,
<hpa@...or.com>
Subject: Re: [Xen-devel] [PATCH V3 3/8] xen: Delay m2p_override initialization
On 11/11/14 05:43, Juergen Gross wrote:
> The m2p overrides are used to be able to find the local pfn for a
> foreign mfn mapped into the domain. They are used by driver backends
> having to access frontend data.
>
> As this functionality isn't used in early boot it makes no sense to
> initialize the m2p override functions very early. It can be done
> later without doing any harm, removing the need for allocating memory
> via extend_brk().
>
> While at it make some m2p override functions static as they are only
> used internally.
Reviewed-by: David Vrabel <david.vrabel@...rix.com>
But...
> static struct page *m2p_find_override(unsigned long mfn)
> {
> unsigned long flags;
> - struct list_head *bucket = &m2p_overrides[mfn_hash(mfn)];
> + struct list_head *bucket;
> struct page *p, *ret;
if (unlikely(!m2p_overrides))
return NULL;
Would be preferred,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists