[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2014 13:47:08 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Soren Brinkmann <soren.brinkmann@...inx.com>
Cc: Michal Simek <michal.simek@...inx.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Alessandro Rubini <rubini@...pv.it>,
Heiko Stuebner <heiko@...ech.de>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
linux-rockchip@...ts.infradead.org,
"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>
Subject: Re: [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property
On Mon, Nov 3, 2014 at 8:05 PM, Soren Brinkmann
<soren.brinkmann@...inx.com> wrote:
> With the new 'groups' property, the DT parser can infer the map type
> from the fact whether 'pins' or 'groups' is used to specify the pin
> group to work on.
> To maintain backwards compatibitliy with current usage of the DT
> binding, this is only done when an invalid map type is passed to the
> parsing function.
So that is this:
> + if (type == PIN_MAP_TYPE_INVALID)
> + type = PIN_MAP_TYPE_CONFIGS_GROUP;
> + dt_pin_specifier = "groups";
This is just kludgy. There are only two kernel-internal users of this function,
refactor the function signature and change the other callers over instead,
patch the drivers.
Take this opportunity to add some kerneldoc above the
pinconf_generic_dt_subnode_to_map() and give the function a
reasonable signature.
BTW: this is just for config settings for groups right? Not for muxing
I hope?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists