[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 11 Nov 2014 18:30:23 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
mturquette@...aro.org, amit.kucheria@...aro.org,
vincent.guittot@...aro.org, daniel.lezcano@...aro.org,
Morten.Rasmussen@....com, efault@....de, nicolas.pitre@...aro.org,
dietmar.eggemann@....com, pjt@...gle.com, bsegall@...gle.com,
mingo@...nel.org, linaro-kernel@...ts.linaro.org,
Preeti U Murthy <preeti@...ux.vnet.ibm.com>
Subject: Re: [RFC 1/2] sched/fair: Add cumulative average of load_avg_contrib
to a task
On Tue, Nov 11, 2014 at 08:22:55PM +0530, Shilpasri G Bhat wrote:
> On 11/10/2014 07:19 PM, Peter Zijlstra wrote:
> > It it broken because who says rq->prev still exists?
>
> 'task_cumulative_load()' is handled by the cpufreq governor's kworker.
> And the kworker is queued only if there is task running on cpu which
> guarantees the existence of rq->prev in a running state.
Not so, there is no guarantee it will still be running by the time the
kworker actually comes around to running.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists