linux-kernel - Re: [PATCH] pstore: Use memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Nov 2014 10:10:57 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Furquan Shaikh <furquan@...gle.com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Olof Johansson <olofj@...gle.com>,
	Aaron Durbin <adurbin@...gle.com>
Subject: Re: [PATCH] pstore: Use memcpy_toio instead of memcpy

On Thu, Nov 13, 2014 at 10:09 AM, Furquan Shaikh <furquan@...gle.com> wrote:
> persistent_ram_update uses vmap / iomap based on whether the buffer is in memory
> region or reserved region. However, both map it as non-cacheable memory. For
> armv8 specifically, non-cacheable mapping requests use a memory type that has to
> be accessed aligned to the request size. memcpy() doesn't guarantee that.
>
> Signed-off-by: Furquan Shaikh <furquan@...gle.com>
> ---
>  fs/pstore/ram_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
> index 9d7b9a8..cfbc5e4 100644
> --- a/fs/pstore/ram_core.c
> +++ b/fs/pstore/ram_core.c
> @@ -299,7 +299,7 @@ static void notrace persistent_ram_update(struct persistent_ram_zone *prz,
>         const void *s, unsigned int start, unsigned int count)
>  {
>         struct persistent_ram_buffer *buffer = prz->buffer;
> -       memcpy(buffer->data + start, s, count);
> +       memcpy_toio(buffer->data + start, s, count);
>         persistent_ram_update_ecc(prz, start, count);
>  }
>
> --
> 2.1.0.rc2.206.gedb03e5
>

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/