linux-kernel - Re: [PATCH] staging: media: bcm2048: fix coding style error

Open Source and information security mailing list archives

Date:	Sat, 15 Nov 2014 21:59:34 +0100
From:	Pavel Machek <pavel@....cz>
To:	Konrad Zapalowicz <bergo.torino@...il.com>
Cc:	Christian Resell <christian.resell@...il.com>,
	m.chehab@...sung.com, devel@...verdev.osuosl.org, askb23@...il.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	yongjun_wei@...ndmicro.com.cn, hans.verkuil@...co.com,
	pali.rohar@...il.com, fengguang.wu@...el.com,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix coding style error

On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> On 11/15, Christian Resell wrote:
> > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > For the eudyptula challenge (http://eudyptula-challenge.org/).
> 
> Nice, however we do not need the information about the 'eudyptula
> challenge' in the commit message.
> 
> If you want to include extra information please do it after the '---'
> line (just below the signed-off). You will find more details in the
> SubmittingPatches (chapter 15) of the kernel documentation.

Greg is staging tree maintainer... And if single extra space is all
you can fix in the driver, perhaps it is not worth the patch?

									Pavel

> Thanks,
> Konrad
>  
> > Signed-off-by: Christian F. Resell <christian.resell@...il.com>
> > ---
> > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > index 2bba370..bdc6854 100644
> > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > @@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
> >   *	bcm2048_i2c_driver - i2c driver interface
> >   */
> >  static const struct i2c_device_id bcm2048_id[] = {
> > -	{ "bcm2048" , 0 },
> > +	{ "bcm2048", 0 },
> >  	{ },
> >  };
> >  MODULE_DEVICE_TABLE(i2c, bcm2048_id);
> > _______________________________________________
> > devel mailing list
> > devel@...uxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives