linux-kernel - Re: [PATCH 2/3] mfd/axp20x: avoid irq numbering collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Nov 2014 15:24:43 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	IIO <linux-iio@...r.kernel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Carlo Caione <carlo@...one.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Ramakrishna Pallala <ramakrishna.pallala@...el.com>,
	Todd Brandt <todd.e.brandt@...ux.intel.com>,
	Peter Meerwald <pmeerw@...erw.net>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Hartmut Knaack <knaack.h@....de>
Subject: Re: [PATCH 2/3] mfd/axp20x: avoid irq numbering collision

On Tue, 11 Nov 2014, Jacob Pan wrote:

> IRQ numbers in axp20x devices are defined with high-order bit first
> in each IRQ enable/status registers. On Intel platforms it is more
> common to number IRQs with least significant bit first. Therefore,
> sharing IRQ# between the two is very difficult. Since AXP288 is a
> customized PMIC for Intel platform and the amount of shared IRQs are
> very small, we use separate IRQ numbering. This also fixes collision
> and a duplicate in WBTO interrupt.
> 
> e.g. For the 16 interrupts controlled in IRQ enabled registers 1 & 2,
> on axp20x for ARM, the PMIC local IRQ numbers and register bits are
> mapped as:
> IRQ#:  0  1  2  3  4  5  6  7      8  9 10 11 12 13 14 15
> ---------------------------------------------------------
> ARM:   7  6  5  4  3  2  1  0      7  6  5  4  3  2  1  0
> Intel: 0  1  2  3  4  5  6  7      0  1  2  3  4  5  6  7
> 
> Signed-off-by: Todd Brandt <todd.e.brandt@...ux.intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> ---
>  drivers/mfd/axp20x.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index daf3c8d..0a8fcd9 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -183,21 +183,21 @@ static const struct regmap_irq axp20x_regmap_irqs[] = {
>  
>  /* some IRQs are compatible with axp20x models */
>  static const struct regmap_irq axp288_regmap_irqs[] = {
> -	INIT_REGMAP_IRQ(AXP20X, VBUS_REMOVAL,           0, 2),
> -	INIT_REGMAP_IRQ(AXP20X, VBUS_PLUGIN,            0, 3),
> -	INIT_REGMAP_IRQ(AXP20X, VBUS_OVER_V,            0, 4),
> +	INIT_REGMAP_IRQ(AXP288, VBUS_FALL,              0, 2),
> +	INIT_REGMAP_IRQ(AXP288, VBUS_RISE,              0, 3),
> +	INIT_REGMAP_IRQ(AXP288, OV,                     0, 4),
>  
> -	INIT_REGMAP_IRQ(AXP20X, CHARG_DONE,             1, 2),
> -	INIT_REGMAP_IRQ(AXP20X, CHARG,                  1, 3),
> +	INIT_REGMAP_IRQ(AXP288, DONE,                   1, 2),
> +	INIT_REGMAP_IRQ(AXP288, CHARGING,               1, 3),
>  	INIT_REGMAP_IRQ(AXP288, SAFE_QUIT,              1, 4),
>  	INIT_REGMAP_IRQ(AXP288, SAFE_ENTER,             1, 5),
> -	INIT_REGMAP_IRQ(AXP20X, BATT_REMOVAL,           1, 6),
> -	INIT_REGMAP_IRQ(AXP20X, BATT_PLUGIN,            1, 7),
> +	INIT_REGMAP_IRQ(AXP288, ABSENT,                 1, 6),
> +	INIT_REGMAP_IRQ(AXP288, APPEND,                 1, 7),
>  
>  	INIT_REGMAP_IRQ(AXP288, QWBTU,                  2, 0),
>  	INIT_REGMAP_IRQ(AXP288, WBTU,                   2, 1),
>  	INIT_REGMAP_IRQ(AXP288, QWBTO,                  2, 2),
> -	INIT_REGMAP_IRQ(AXP288, WBTU,                   2, 3),
> +	INIT_REGMAP_IRQ(AXP288, WBTO,                   2, 3),
>  	INIT_REGMAP_IRQ(AXP288, QCBTU,                  2, 4),
>  	INIT_REGMAP_IRQ(AXP288, CBTU,                   2, 5),
>  	INIT_REGMAP_IRQ(AXP288, QCBTO,                  2, 6),
> @@ -215,7 +215,7 @@ static const struct regmap_irq axp288_regmap_irqs[] = {
>  	INIT_REGMAP_IRQ(AXP288, POKS,                   4, 4),
>  	INIT_REGMAP_IRQ(AXP288, POKN,                   4, 5),
>  	INIT_REGMAP_IRQ(AXP288, POKP,                   4, 6),
> -	INIT_REGMAP_IRQ(AXP20X, TIMER,                  4, 7),
> +	INIT_REGMAP_IRQ(AXP288, TIMER,                  4, 7),
>  
>  	INIT_REGMAP_IRQ(AXP288, MV_CHNG,                5, 0),
>  	INIT_REGMAP_IRQ(AXP288, BC_USB_CHNG,            5, 1),

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/