linux-kernel - [PATCH] perf symbols: Consider the syms_ss in dso__load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2014 10:54:57 +0000
From:	Steve Capper <steve.capper@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>, will.deacon@....com,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Steve Capper <steve.capper@...aro.org>
Subject: [PATCH] perf symbols: Consider the syms_ss in dso__load_sym

In dso__load_sym we only try to load the .debug_frame section from the
runtime image. For distros, the debug symbols are generally in a
separate file.

As a result, running perf report on arm64 can give errors such as:
"$file with build id $id not found, continuing without symbols"

Even when the debug symbols have been correctly installed (and loaded
by perf).

This patch adds logic to dso__load_sym to query syms_ss for the
.debug_frame section if it can't be found in the elf file pointed to by
runtime_ss.

Signed-off-by: Steve Capper <steve.capper@...aro.org>
---
This patch is against 3.18-rc5.
---
 tools/perf/util/symbol-elf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index 1e23a5b..1336392 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -830,8 +830,11 @@ int dso__load_sym(struct dso *dso, struct map *map,
 			continue;
 
 		sec = elf_getscn(runtime_ss->elf, sym.st_shndx);
-		if (!sec)
-			goto out_elf_end;
+		if (!sec) {
+			sec = elf_getscn(syms_ss->elf, sym.st_shndx);
+			if (!sec)
+				goto out_elf_end;
+		}
 
 		gelf_getshdr(sec, &shdr);
 
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/