linux-kernel - Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2014 20:40:56 +0000
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, jarod@...sonet.com,
	m.chehab@...sung.com, gregkh@...uxfoundation.org,
	mahfouz.saif.elyazal@...il.com, dan.carpenter@...cle.com,
	tuomas.tynkkynen@....fi, gulsah.1004@...il.com,
	linux-media@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings
 split across lines

On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote:
> On Tue, 2014-11-25 at 20:19 +0000, Luis de Bethencourt wrote:
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle recommends not splitting quotes strings across lines
> > because it breaks the ability to grep for the string. Fixing these.
> []
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> []
> > @@ -794,8 +792,7 @@ static int fw_load(struct IR_tx *tx)
> >  	if (!read_uint8(&data, tx_data->endp, &version))
> >  		goto corrupt;
> >  	if (version != 1) {
> > -		dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected"
> > -			    "1) -- please upgrade to a newer driver",
> > +		dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected1) -- please upgrade to a newer driver",
> >  			    version);
> 
> Hello Luis.
> 
> Please look at the strings being coalesced before
> submitting patches.
> 
> It's a fairly common defect to have either a missing
> space between the coalesced fragments or too many
> spaces.
> 
> It's almost certain that there should be a space
> between the "expected" and "1" here.
> 
> 

Hello Joe,

Thanks for taking the time to review this. I sent a new
version fixing the missing space. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/