linux-kernel - Re: [PATCH v2] regmap: provide dummy regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2014 21:14:31 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Olof Johansson <olof@...om.net>
Cc:	linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2] regmap: provide dummy regmap_exit()

On Tue, Nov 25, 2014 at 01:03:19PM -0800, Olof Johansson wrote:
> Fixes build error:
> 
> sound/soc/soc-core.c: In function 'snd_soc_component_exit_regmap':
> sound/soc/soc-core.c:2644:2: error: implicit declaration of function 'regmap_exit' [-Werror=implicit-function-declaration]
>   regmap_exit(component->regmap);

In which configuration?

> Due to the other regmap functions providing appropriate stubs when
> !CONFIG_REGMAP, but this one is missing. Add it.

Be careful on this one, you'll notice that the matching creation
functions *aren't* stubbed since there is no way to reference them
without an active dependency on regmap and indeed this use is a bit
dodgy since the core ends up freeing something that a driver allocated
which isn't ideal but probably is OK due to the general horrificness of
the AC'97 device model integration.  We only stub functions that generic
code might have a sensible reason to use in order to make it less faff
to provide generic helpers for things.  

I'll tweak the commit message when applying.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)