linux-kernel - Re: [PATCH] of: support passing console options with stdout-path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2014 15:15:16 +0000
From:	Leif Lindholm <leif.lindholm@...aro.org>
To:	Grant Likely <grant.likely@...aro.org>
Cc:	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, mark.rutland@....com,
	robh+dt@...nel.org, plagnioj@...osoft.com, ijc@...ian.org
Subject: Re: [PATCH] of: support passing console options with stdout-path

On Tue, Nov 25, 2014 at 02:58:54PM +0000, Grant Likely wrote:
> > +		len = strchrnul(path, ':') - path;
> > +
> >  		for_each_property_of_node(of_aliases, pp) {
> >  			if (strlen(pp->name) == len && !strncmp(pp->name, path, len)) {
> >  				np = of_find_node_by_path(pp->value);
> 
> Can you add a testcase to drivers/of/unittests.c for this new path
> parsing? Then we know it's correct!

Will do.
 
> > @@ -1830,8 +1835,12 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
> >  			name = of_get_property(of_chosen, "linux,stdout-path", NULL);
> >  		if (IS_ENABLED(CONFIG_PPC) && !name)
> >  			name = of_get_property(of_aliases, "stdout", NULL);
> > -		if (name)
> > +		if (name) {
> >  			of_stdout = of_find_node_by_path(name);
> > +			of_stdout_options = strchr(name, ':');
> > +			if (of_stdout_options != NULL)
> > +				of_stdout_options++;
> > +		}
> 
> Not so good. The ':' should actually be a generic part of
> of_find_node_by_path(), it doesn't have to be limited to stdout parsing.
> There are other places that would use it. I would add a second,
> optional, argument to of_find_node_by_path() that will update a pointer
> to the arguments after the ':'.

So, I agree this would be nicer...

However, I'm counting 157 callers of this function outside of
drivers/of and 43 inside. Any chance you'd let me get away with a
separate of_find_extra_options_by_path()?

/
    Leif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/