linux-kernel - Re: [PATCH] media: exynos-gsc: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Nov 2014 15:18:34 +0000
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc:	Kukjin Kim <kgene.kim@...sung.com>,
	LMML <linux-media@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>
Subject: Re: [PATCH] media: exynos-gsc: fix build warning

Hi Mauro,

On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab
<mchehab@....samsung.com> wrote:
> Em Tue, 18 Nov 2014 10:57:48 +0000
[Snip]
>
> -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index)
> +static int get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index, u32 *ret_addr)
>  {
>         if (frm->addr.y == addr) {
>                 *index = 0;
> -               return frm->addr.y;
> +               *ret_addr = frm->addr.y;
>         } else if (frm->addr.cb == addr) {
>                 *index = 1;
> -               return frm->addr.cb;
> +               *ret_addr = frm->addr.cb;
>         } else if (frm->addr.cr == addr) {
>                 *index = 2;
> -               return frm->addr.cr;
> +               *ret_addr = frm->addr.cr;
>         } else {
>                 pr_err("Plane address is wrong");
>                 return -EINVAL;
>         }
> +       return 0;
the control wont reach here! may be you can remove the complete else
part outside ?

with that change,

Reported-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Thanks,
--Prabhakar Lad

>  }
>
>  void gsc_set_prefbuf(struct gsc_dev *gsc, struct gsc_frame *frm)
> @@ -352,9 +353,11 @@ void gsc_set_prefbuf(struct gsc_dev *gsc, struct gsc_frame *frm)
>                 u32 t_min, t_max;
>
>                 t_min = min3(frm->addr.y, frm->addr.cb, frm->addr.cr);
> -               low_addr = get_plane_info(frm, t_min, &low_plane);
> +               if (get_plane_info(frm, t_min, &low_plane, &low_addr))
> +                       return;
>                 t_max = max3(frm->addr.y, frm->addr.cb, frm->addr.cr);
> -               high_addr = get_plane_info(frm, t_max, &high_plane);
> +               if (get_plane_info(frm, t_max, &high_plane, &high_addr))
> +                       return;
>
>                 mid_plane = 3 - (low_plane + high_plane);
>                 if (mid_plane == 0)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/