linux-kernel - Re: [PATCH] Drivers:staging:speakup: Fixed checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2014 12:26:39 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Athira Lekshmi C V <andnlnbn18@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, domagoj.trsan@...il.com,
	aysemelikeyurtoglu@...il.com, speakup@...ux-speakup.org,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Drivers:staging:speakup: Fixed checkpatch warning

On Wed, Nov 26, 2014 at 12:14 PM, Athira Lekshmi C V
<andnlnbn18@...il.com> wrote:
> Fixed the checkpatch warning:
> WARNING: simple_strtoul is obsolete, use kstrtoul instead
>
> Signed-off-by: Athira Lekshmi C V <andnlnbn18@...il.com>
> ---
>  drivers/staging/speakup/varhandlers.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
> index 1b0d1c0..00fd67e 100644
> --- a/drivers/staging/speakup/varhandlers.c
> +++ b/drivers/staging/speakup/varhandlers.c
> @@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
>  {
>         int val = 0;
>
> -       val = simple_strtoul(skip_spaces(start), &start, 10);
> +       val = kstrtoul(skip_spaces(start), &start, 10);
>         if (*start == ',')
>                 start++;
>         *dest = (u_char)val;

NACK.

Please test your patch or at least read the function signature kstrtoul().

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/