linux-kernel - Re: [PATCH] ARM: decompressor: fix a wrong comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Nov 2014 02:15:41 -0500 (EST)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Masahiro Yamada <yamada.m@...panasonic.com>
cc:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Kevin Hilman <khilman@...aro.org>,
	Will Deacon <will.deacon@....com>,
	Heiko Stuebner <heiko@...ech.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: decompressor: fix a wrong comment

On Fri, 28 Nov 2014, Masahiro Yamada wrote:

> This comment does not correspond to the actual code.
> 
> When zImage is loaded at a lower *OR* higher address of
> the destination of Image, it won't overwrite itself.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@...panasonic.com>

Acked-by: Nicolas Pitre <nico@...aro.org>


> ---
> 
>  arch/arm/boot/compressed/head.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index 68be901..9dff614 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -178,7 +178,7 @@ not_angel:
>  
>  		/*
>  		 * Set up a page table only if it won't overwrite ourself.
> -		 * That means r4 < pc && r4 - 16k page directory > &_end.
> +		 * That means r4 < pc || r4 - 16k page directory > &_end.
>  		 * Given that r4 > &_end is most unfrequent, we add a rough
>  		 * additional 1MB of room for a possible appended DTB.
>  		 */
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/