linux-kernel - Re: [PATCH 5/8] of/overlay: Introduce DT overlay support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Nov 2014 00:07:13 +0000
From:	Grant Likely <grant.likely@...aro.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 5/8] of/overlay: Introduce DT overlay support

On Wed, 26 Nov 2014 17:57:05 +0100
, Paul Bolle <pebolle@...cali.nl>
 wrote:
> On Wed, 2014-11-26 at 15:18 +0000, Grant Likely wrote:
> > On Wed, Nov 26, 2014 at 1:11 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> > > On Fri, 2014-11-21 at 01:35 +0000, Grant Likely wrote:
> > >> From: Pantelis Antoniou <pantelis.antoniou@...sulko.com>
> > >>
> > >> Overlays are a method to dynamically modify part of the kernel's
> > >> device tree with dynamically loaded data. Add the core functionality to
> > >> parse, apply and remove an overlay changeset. The core functionality
> > >> takes care of managing the overlay data format and performing the add
> > >> and remove. Drivers are expected to use the overlay functionality to
> > >> support custom expansion busses commonly found on consumer development
> > >> boards like the BeagleBone or Raspberry Pi.
> > >>
> > >> The overlay code uses CONFIG_OF_DYNAMIC changesets to perform the low
> > >> level work of modifying the devicetree.
> > >>
> > >> Documentation about internal and APIs is provided in
> > >>       Documentation/devicetree/overlay-notes.txt
> > >>
> > >> v2:
> > >> - Switch from __of_node_alloc() to __of_node_dup()
> > >> - Documentation fixups
> > >> - Remove 2-pass processing of properties
> > >> - Remove separate ov_lock; just use the DT mutex.
> > >> v1:
> > >> - Drop delete capability using '-' prefix. The '-' prefixed names
> > >> are valid properties and nodes and there is no need for it just yet.
> > >> - Do not update special properties - name & phandle ones.
> > >> - Change order of node attachment, so that the special property update
> > >> works.
> > >>
> > >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@...sulko.com>
> > >> Signed-off-by: Grant Likely <grant.likely@...aro.org>
> > >
> > > Now commit 7518b5890d8a ("of/overlay: Introduce DT overlay support"),
> > > included in today's linux-next (next-20141126).
> > 
> > Yes, I pushed it out yesterday. Beyond merely stating a fact, I don't
> > understand what you're trying to point out here. Is this commit
> > causing a problem?
> 
> Yes, the issue I pointed out in my next remark.
> 
> And I add a boring line like that to my messages to make sure its
> readers (which could be me, in case nothing happens within a week or
> two) have all the facts at hand when handling them. It spares them the
> trouble to look up these facts themselves.
> 
> Perhaps this lines was ambiguous. Should I rephrase it? Please note that
> I usually use proper sentences. This one was a bit blunt. 

I was confused because the statement above wasn't in reference to
anything in particular. It was just a statement. If you had said
something like "Today's linux-next has the following problem caused by
commit 7518b5890 ('...')", then I think it would have been clearer.

> 
> > >>[...]
> > >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> > >> index fbe8f8d418f7..18b2e2539f84 100644
> > >> --- a/drivers/of/Kconfig
> > >> +++ b/drivers/of/Kconfig
> > >> @@ -84,4 +84,11 @@ config OF_RESERVED_MEM
> > >>  config OF_RESOLVE
> > >>       bool
> > >>
> > >> +config OF_OVERLAY
> > >> +     bool
> > >> +     depends on OF
> > >> +     select OF_DYNAMIC
> > >> +     select OF_DEVICE
> > >
> > > There's currently no Kconfig symbol OF_DEVICE. So this select is now a
> > > nop. Will that symbol be added in a future patch?
> > 
> > That's a hanger-on from an earlier version of the patch. I'll apply a
> > fixup patch to remove it.
> 
> I've seen your fixup already. It turns out OF_DEVICE is a symbol that
> was removed in v3.11.

Thanks for the testing and bug report.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/