linux-kernel - Re: [PATCH v2 RESEND 1/2] ARM: vexpress: Remove non-DT code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Nov 2014 17:31:45 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Pawel Moll <pawel.moll@....com>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"arm@...nel.org" <arm@...nel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Liviu Dudau <Liviu.Dudau@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sudeep Holla <Sudeep.Holla@....com>
Subject: Re: [PATCH v2 RESEND 1/2] ARM: vexpress: Remove non-DT code

On Friday 28 November 2014 15:53:04 Pawel Moll wrote:
> vmmc-supply is a defined as:
> 
>                                 vmmc-supply = <&v2m_fixed_3v3>;
> 
> which is:
> 
>                 v2m_fixed_3v3: fixedregulator@0 {
>                         compatible = "regulator-fixed";
> 
> and arch/arm/mach-vexpress/Kconfig says:
> 
> menuconfig ARCH_VEXPRESS
> [...]
>         select REGULATOR_FIXED_VOLTAGE if REGULATOR
> 
> but it doesn't select REGULATOR in result of this discussion:
> 
> http://thread.gmane.org/gmane.linux.ports.arm.kernel/223426/focus=223427
> 
> To summarize, I believe that setting CONFIG_REGULATOR=y (as in
> vexpress_defconfig) should solve your issue.

Well, there is clearly a bug somewhere. As you say, the mmc driver
now uses the regulator API to check the voltage instead of using
platform_data. But there is no dependency on having the regulator
support around, so it can't.

I would suggest applying your patch from
http://thread.gmane.org/gmane.linux.ports.arm.kernel/223426/focus=224128
after all, or just hardcoding regulator support like a lot of other
platforms do.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/