| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Dec 2014 14:04:37 +0100 From: Pavel Machek <pavel@....cz> To: Jacek Anaszewski <j.anaszewski@...sung.com> Cc: linux-leds@...r.kernel.org, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, kyungmin.park@...sung.com, b.zolnierkie@...sung.com, cooloney@...il.com, rpurdie@...ys.net, sakari.ailus@....fi, s.nawrocki@...sung.com Subject: Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension Hi! > >How are faults cleared? Should it be list of strings, instead of > >bitmask? We may want to add new fault modes in future... > > Faults are cleared by reading the attribute. I will add this note. > There can be more than one fault at a time. I think that the bitmask > is a flexible solution. I don't see any troubles related to adding > new fault modes in the future, do you? I do not think that "read attribute to clear" is good idea. Normally, you'd want the error attribute world-readable, but you don't want non-root users to clear the errors. I am not sure if bitmask is good solution. I'd return space-separated strings like "overtemp". That way, there's good chance that other LED drivers would be able to use similar interface... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists