lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Dec 2014 10:24:46 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Ben Hutchings <ben@...adent.org.uk> Cc: Hisashi T Fujinaka <htodd@...fifty.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Bruce Allan <bruce.w.allan@...el.com>, Carolyn Wyborny <carolyn.wyborny@...el.com>, Don Skidmore <donald.c.skidmore@...el.com>, Greg Rose <gregory.v.rose@...el.com>, Matthew Vick <matthew.vick@...el.com>, John Ronciak <john.ronciak@...el.com>, Mitch Williams <mitch.a.williams@...el.com>, Linux NICS <linux.nics@...el.com>, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] e1000: remove unused variables On Sun, Nov 30, 2014 at 01:45:13AM +0000, Ben Hutchings wrote: > On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote: > > I'm pretty sure those double reads are there for a reason, so most of > > this I'm going to have to check on Monday. We have a long holiday > > weekend here in the US. > [...] > > If there were double register reads being replaced with single register > reads, I'd agree this was likely to introduce a regression. But all I > see is var = er32(REG) being changed to er32(REG). no, double register reads are not modified. only the unused variables are removed. thanks sudip > > Ben. > > -- > Ben Hutchings > The world is coming to an end. Please log off. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists