| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Dec 2014 22:57:47 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Stephan Mueller <smueller@...onox.de> Cc: linux-crypto@...r.kernel.org, 'LKML' <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] crypto: algif_skcipher - initialize upon init request On Sun, Nov 30, 2014 at 10:55:26AM +0100, Stephan Mueller wrote: > When using the algif_skcipher, the following call sequence causess a > re-initialization: > > 1. sendmsg with ALG_SET_OP and iov == NULL, iovlen == 0 (i.e > initializing the cipher, but not sending data) > > 2. sendmsg with msg->msg-controllen == 0 and iov != NULL (using the initalized > cipher handle by sending data) > > In step 2, the cipher operation type (encryption or decryption) is reset > to always decryption, because the local variable of enc is put into > ctx->enc as ctx->user is still zero. > > The same applies when all send data is processed and ctx->used falls to > zero followed by user space to send new data. > > This patch changes the behavior to only reset the cipher operation type > (and the IV) if such configuration request is received. > > Signed-off-by: Stephan Mueller <smueller@...onox.de> Patch applied. -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists