linux-kernel - Re: Fix me in libata-scsi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 2 Dec 2014 13:07:43 -0500
From:	Tejun Heo <tj@...nel.org>
To:	nick <xerofoify@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Fix me in libata-scsi.c

On Mon, Nov 17, 2014 at 08:19:40PM -0500, nick wrote:
> I am wondering about the fix me in following code in the file listed
> in my message. Seems this is necessary from reading the code and the
> FIX ME is no longer needed as the memset is correct and needed for
> the function.

Yeah, I think the sense buffer clearing is the right thing regardless
of it being not strictly necessary for all devices.  There's no point
in not clearing it.  Please feel free to send a patch to remove the
comment.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/