linux-kernel - Re: [RESEND PATCH] ima: Fix build failure on powerpc when TCG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 04 Dec 2014 11:13:10 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, d.kasatkin@...sung.com,
	james.l.morris@...cle.com, serge@...lyn.com,
	linux-ima-devel@...ts.sourceforge.net,
	linux-security-module@...r.kernel.org,
	Lo Hon Ching <lo1@...ibm.com>,
	Ashley Lai <ashley@...leylai.com>,
	George Wilson <gcwilson@...ibm.com>
Subject: Re: [RESEND PATCH] ima: Fix build failure on powerpc when
 TCG_IBMVTPM dependencies are not met

On Wed, 2014-12-03 at 09:48 -0500, Mimi Zohar wrote:
> On Wed, 2014-12-03 at 17:04 +1100, Michael Ellerman wrote: 
> > On powerpc we can end up with IMA=y and PPC_PSERIES=n which leads to:
> > 
> >   warning: (IMA) selects TCG_IBMVTPM which has unmet direct dependencies (TCG_TPM && PPC_PSERIES)
> >   tpm_ibmvtpm.c:(.text+0x14f3e8): undefined reference to `.plpar_hcall_norets'
> > 
> > I'm not sure why IMA needs to select those user-visible symbols, but if
> > it must then the simplest fix is to just express the proper dependencies
> > on the select.
> 
> On systems without a TPM, IMA goes into a "by-pass" mode, which stores
> the measurements without extending the TPM PCR.  On Power, there isn't a
> HW TPM, but on Power running PowerVM there is a virtual TPM(vTPM).  On
> Power running PowerKVM there isn't support for vTPM, yet.  The Kconfig
> needs to differentiate between the two.

No it doesn't. We don't build different configs for guests on PowerVM vs
PowerKVM. The code needs to handle detecting the presence or absence of the
vTPM at runtime.

But none of that relates to this build fix AFAICS.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/