linux-kernel - Re: [PATCH 3/4] iio: dht11: Logging updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Dec 2014 15:25:06 +0100
From:	Harald Geyer <harald@...ib.org>
To:	Richard Weinberger <richard@....at>
cc:	jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
	pmeerw@...erw.net, sanjeev_sharma@...tor.com,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] iio: dht11: Logging updates

Richard Weinberger writes:
> Am 03.12.2014 um 14:56 schrieb Harald Geyer:
> > Richard Weinberger writes:
> >> Am 03.12.2014 um 13:58 schrieb Harald Geyer:
> >> Currently we get log messages of style:
> >> "iio iio:deviceX: foo bar"
> >> and:
> >> "dht11 <name in DT>: foo bar"
> >>
> >> I really favorite "dht11 <name in DT".
> >> In my device tree every senor has a sane name and log messages look like:
> >> "dht11 toiletten sensor: invalid checksum"
> > 
> > I think I ACKed the one with "iio iio:deviceX: foo bar"? 
> 
> No, my patch turns all logs to "dht11 <name in DT>: foo bar".

Maybe I was unclear. AFAICS there is one case where we actually have
"iio iio:deviceX: foo bar" now and I said:

> @@ -193,7 +197,7 @@ static int dht11_read_raw(struct iio_dev *iio_dev,
>               free_irq(dht11->irq, iio_dev);
>
>               if (ret == 0 && dht11->num_edges < DHT11_EDGES_PER_READ - 1) {
> -                     dev_err(&iio_dev->dev,
> +                     dev_err(dht11->dev,

Ack.

Hope that clarifies,
Harald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/