linux-kernel - RE: [PATCH v2] sched/fair: fix find_idlest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Dec 2014 01:48:25 +0000
From:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
To:	Vincent Guittot <vincent.guittot@...aro.org>,
	"Zhang, Jun" <jun.zhang@...el.com>
CC:	"mingo@...hat.com" <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Hillf Danton <hillf.zj@...baba-inc.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"Liu, Changcheng" <changcheng.liu@...el.com>
Subject: RE: [PATCH v2] sched/fair: fix find_idlest_cpu return -1



> -----Original Message-----
> From: Vincent Guittot [mailto:vincent.guittot@...aro.org]
> Sent: Thursday, December 04, 2014 8:15 PM
> To: Zhang, Jun
> Cc: mingo@...hat.com; Peter Zijlstra; gregkh@...uxfoundation.org; Hillf
> Danton; linux-kernel; stable@...r.kernel.org; Liu, Chuansheng; Liu,
> Changcheng
> Subject: Re: [PATCH v2] sched/fair: fix find_idlest_cpu return -1
> 
> On 4 December 2014 at 12:43,  <jun.zhang@...el.com> wrote:
> > From: zhang jun <jun.zhang@...el.com>
> >
> > in function select_task_rq_fair, when find_idlest_cpu return -1 and sd->child
> == NULL
> > select_task_rq_fair return -1, system panic.
> 
> you forgot to add on which kernel version this patch applies.
> 
> We don't have such issue on 3.18-rc7 as find_idlest_cpu don't return
> -1. We only need a cleanup of the test against -1 for 3.18-rc
> 
Agreed, so Jun can make two patches:
The first one patch is in find_idlest_cpu() to not return -1 and based on stable-branch such as 3.14.x;
The second patch is one cleanup for new_cpu == -1 judgment against the 3.18-rc, since it is no possibility now;

Best Regards
Chuansheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/