linux-kernel - Re: [PATCH] dell-smo8800: Add more acpi ids and change description of driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Dec 2014 05:43:23 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH] dell-smo8800: Add more acpi ids and change description
 of driver

On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote:
> Oops, I lost this mail somewhere...
> 
> I copied these ids from windows driver inf file. I did not tested 
> them because I do not have machine which reports these ids. It 
> looks like all SMOXX devices have same acpi structure (one IRQ). 
> So adding ids could not break anything (if acpi device will not 
> have for some reason IRQ specified, device probe function will 
> fail).

Please resend with a complete message body and the typo fix below.

> 
> On Monday 29 September 2014 22:56:04 Darren Hart wrote:
> > On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:
> > 
> > Please see Documentation/SubmittingPatches, 15) The canonical
> > patch format, and provide a complete message body.
> > 
> > Have you validated each of the 6 ACPI IDs added to the driver?
> > 
> > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > > ---
> > > 
> > >  drivers/platform/x86/Kconfig        |    4 ++--
> > >  drivers/platform/x86/dell-smo8800.c |   10 ++++++++--
> > >  2 files changed, 10 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/platform/x86/Kconfig
> > > b/drivers/platform/x86/Kconfig index 3bbcbf1..ba9ee4f
> > > 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> > > 
> > >  	  be called dell-wmi-aio.
> > >  
> > >  config DELL_SMO8800
> > > 
> > > -	tristate "Dell Latitude freefall driver (ACPI
> > > SMO8800/SMO8810)" +	tristate "Dell Latitude freefall driver
> > > (ACPI SMO88XX)"
> > > 
> > >  	depends on ACPI
> > >  	---help---
> > > 
> > > -	  Say Y here if you want to support SMO8800/SMO8810
> > > freefall device +	  Say Y here if you want to support
> > > SMO88XX freefall device
> > 
> > "devices" now that multiple are supported.
> > 
> > Thanks,
> 
> -- 
> Pali Rohár
> pali.rohar@...il.com



-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/