lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Dec 2014 20:24:25 -0800 From: Joe Perches <joe@...ches.com> To: Ray Jui <rjui@...adcom.com> Cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Linus Walleij <linus.walleij@...aro.org>, Alexandre Courbot <gnurou@...il.com>, Grant Likely <grant.likely@...aro.org>, Christian Daudt <bcm@...thebug.org>, Matt Porter <mporter@...aro.org>, Florian Fainelli <f.fainelli@...il.com>, Russell King <linux@....linux.org.uk>, Scott Branden <sbranden@...adcom.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com, devicetree@...r.kernel.org Subject: Re: [PATCH 2/5] gpio: Cygnus: add GPIO driver On Fri, 2014-12-05 at 19:41 -0800, Ray Jui wrote: > On 12/5/2014 6:34 PM, Joe Perches wrote: > > On Fri, 2014-12-05 at 18:14 -0800, Ray Jui wrote: > >> On 12/5/2014 5:28 PM, Joe Perches wrote: > >>> On Fri, 2014-12-05 at 16:40 -0800, Ray Jui wrote: > >>>> + for_each_set_bit(bit, &val, 32) { [] > Actually, by reviewing the code more deeply, I'm not sure why using > for_each_set_bit here is 'endian unsafe'. It's not. The 32 confused me as it was long and sizeof(long) isn't necessarily 32. Maybe the 32 should be a #define -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists