linux-kernel - Re: [PATCH] mm: memcontrol: Skip test_mem_cgroup_node_reclaimable() when no MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 07 Dec 2014 21:53:47 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	hannes@...xchg.org, cgroups@...r.kernel.org,
	" linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: Skip test_mem_cgroup_node_reclaimable()
 when no MAX_NUMNODES or not more than 1

OK, thanks. I shall try to send another patch to upstream kernel
within this month.

Send from Lenovo A788t.

Michal Hocko <mhocko@...e.cz> wrote:

>Hi,
>this has been fixed last week already
>http://marc.info/?l=linux-mm&m=141751847710864&w=2
>
>On Sat 06-12-14 06:27:57, Chen Gang wrote:
>> test_mem_cgroup_node_reclaimable() is only used when "MAX_NUMNODES > 1",
>> so move it into related quote.
>> 
>> The related warning (with allmodconfig under parisc):
>> 
>>     CC      mm/memcontrol.o
>>   mm/memcontrol.c:1629:13: warning: 'test_mem_cgroup_node_reclaimable' defined but not used [-Wunused-function]
>>    static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
>>                ^
>> 
>> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
>> ---
>>  mm/memcontrol.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index c6ac50e..d538b08 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -1616,6 +1616,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
>>  			 NULL, "Memory cgroup out of memory");
>>  }
>>  
>> +#if MAX_NUMNODES > 1
>>  /**
>>   * test_mem_cgroup_node_reclaimable
>>   * @memcg: the target memcg
>> @@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
>>  	return false;
>>  
>>  }
>> -#if MAX_NUMNODES > 1
>>  
>>  /*
>>   * Always updating the nodemask is not very good - even if we have an empty
>> -- 
>> 1.9.3
>
>-- 
>Michal Hocko
>SUSE Labs