linux-kernel - Re: [PATCH] irqchip: mediatek: Fix error return code detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Dec 2014 21:30:51 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yingjoe Chen <yingjoe.chen@...iatek.com>
cc:	Beniamino Galvani <b.galvani@...il.com>,
	Jason Cooper <jason@...edaemon.net>,
	Marc Zyngier <marc.zyngier@....com>,
	srv_heupstream@...iatek.com, hc.yen@...iatek.com,
	yh.chen@...iatek.com, linux-kernel@...r.kernel.org,
	Matthias Brugger <matthias.bgg@...il.com>,
	nathan.chung@...iatek.com, Sascha Hauer <kernel@...gutronix.de>,
	eddie.huang@...iatek.com, yingjoe.chen@...il.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] irqchip: mediatek: Fix error return code detection

On Mon, 8 Dec 2014, Yingjoe Chen wrote:

> This fix an error handling bug reported by Beniamino, this is based on
> mtk intpol patches [1]
>
> Joe.C
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/305808.html
> 
> ====================
> of_io_request_and_map() return ERR_PTR wrapped error code instead of
> NULL when fail, fix code in mtk_sysirq_of_init() to correctly handle
> this.
> 
> Signed-off-by: Yingjoe Chen <yingjoe.chen@...iatek.com>

This is not a proper changelog. Let me write up a proper one:

Subject: irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

Beniamino reported a kernel oops caused by an invalid DT file for the
mediatek interrupt polarity extension.

The reason is that the interrupt polarity support for mediatek chips
merily checks for at NULL pointer instead of a casted error return
value in mtk_sysirq_of_init() so any other casted error value passes
the NULL pointer check and causes a kernel panic when dereferenced.

Use IS_ERR() and return the error value via PTR_ERR().

Reported-and-tested-by: Beniamino Galvani <b.galvani@...il.com>
Signed-off-by: Yingjoe Chen <yingjoe.chen@...iatek.com>

Can you see the difference?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/