linux-kernel - Re: [PATCH v4 4/5] ARM: dts: add rk3288 usb PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Dec 2014 11:26:21 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Yunzhi Li <lyz@...k-chips.com>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/5] ARM: dts: add rk3288 usb PHY

Hi,

Am Dienstag, 9. Dezember 2014, 10:52:34 schrieb Yunzhi Li:
> This patch adds a device_node for RK3288 SoC usb phy. It also
> defines the phy to be used by three usb controllers: usb_host0/1
> and usb_otg.
> 
> Signed-off-by: Yunzhi Li <lyz@...k-chips.com>
> 
> ---
> 
> Changes in v4:
> - Add phy subnodes.
> 
> Changes in v3: None
> 
>  arch/arm/boot/dts/rk3288.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..2db2d12 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -329,12 +329,35 @@
>  		status = "disabled";
>  	};
> 
> +	usbphy: phy {

the nodes in the dts are ordered by address, please move it accordingly. I 
guess a good position might be to have the "phy" before the "pinctrl" node.

Also please reorder the properties a bit to have the "compatible" at the top 
of the list, like

		compatible = "rockchip,rk3288-usb-phy";
		rockchip,grf = <&grf>;
		#phy-cells = <1>;
		#address-cells = <1>;
		#size-cells = <0>;
		status = "disabled";

		subnodes...


Thanks
Heiko

> +		#phy-cells = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "rockchip,rk3288-usb-phy";
> +		rockchip,grf = <&grf>;
> +		status = "disabled";
> +
> +		usb-phy@0 {
> +			reg = <0>;
> +		};
> +
> +		usb-phy@1 {
> +			reg = <1>;
> +		};
> +
> +		usb-phy@2 {
> +			reg = <2>;
> +		};
> +	};
> +
>  	usb_host0_ehci: usb@...00000 {
>  		compatible = "generic-ehci";
>  		reg = <0xff500000 0x100>;
>  		interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
>  		clocks = <&cru HCLK_USBHOST0>;
>  		clock-names = "usbhost";
> +		phys = <&usbphy 1>;
> +		phy-names = "usb";
>  		status = "disabled";
>  	};
> 
> @@ -347,6 +370,8 @@
>  		interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>  		clocks = <&cru HCLK_USBHOST1>;
>  		clock-names = "otg";
> +		phys = <&usbphy 2>;
> +		phy-names = "usb2-phy";
>  		status = "disabled";
>  	};
> 
> @@ -357,6 +382,8 @@
>  		interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>  		clocks = <&cru HCLK_OTG0>;
>  		clock-names = "otg";
> +		phys = <&usbphy 0>;
> +		phy-names = "usb2-phy";
>  		status = "disabled";
>  	};

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/