lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Dec 2014 16:29:57 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, Alistair Popple <alistair@...ple.id.au>, Andrew Morton <akpm@...ux-foundation.org>, Daniel Walter <dwalter@...gle.com>, Li Zhong <zhong@...ux.vnet.ibm.com>, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH] arch: powerpc: kernel: vio.c: Remove unused function On Sun, 2014-12-07 at 23:31 +0100, Rickard Strandqvist wrote: > Remove the function cmo_high_show() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > --- > arch/powerpc/kernel/vio.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c > index 5bfdab9..11657d2 100644 > --- a/arch/powerpc/kernel/vio.c > +++ b/arch/powerpc/kernel/vio.c > @@ -1032,11 +1032,6 @@ viobus_cmo_pool_rd_attr(reserve, size); > viobus_cmo_pool_rd_attr(excess, size); > viobus_cmo_pool_rd_attr(excess, free); > > -static ssize_t cmo_high_show(struct bus_type *bt, char *buf) > -{ > - return sprintf(buf, "%lu\n", vio_cmo.high); > -} from ../arch/powerpc/kernel/vio.c:17: ../arch/powerpc/kernel/vio.c:1046:20: error: 'cmo_high_show' undeclared here (not in a function) static BUS_ATTR_RW(cmo_high); ^ ../include/linux/sysfs.h:76:10: note: in definition of macro '__ATTR' .show = _show, \ ^ ../include/linux/device.h:53:42: note: in expansion of macro '__ATTR_RW' struct bus_attribute bus_attr_##_name = __ATTR_RW(_name) ^ ../arch/powerpc/kernel/vio.c:1046:8: note: in expansion of macro 'BUS_ATTR_RW' static BUS_ATTR_RW(cmo_high); ^ cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists