lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 10 Dec 2014 10:12:49 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Alan Tull <atull@...nsource.altera.com>
Cc:	kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH socfpga-nex] staging: fpga manager:
 fpga_mgr_low_level_state() can be static

drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static?
drivers/staging/fpga/fpga-mgr.c:324:30: sparse: symbol 'fpga_mgr_groups' was not declared. Should it be static?
drivers/staging/fpga/fpga-mgr.c:365:25: sparse: symbol 'fpga_mgr_dev_pm_ops' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---
 fpga-mgr.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fpga/fpga-mgr.c b/drivers/staging/fpga/fpga-mgr.c
index d08cb82..3216276 100644
--- a/drivers/staging/fpga/fpga-mgr.c
+++ b/drivers/staging/fpga/fpga-mgr.c
@@ -43,7 +43,7 @@ static LIST_HEAD(fpga_manager_list);
  *
  * This will be used to initialize framework state
  */
-int fpga_mgr_low_level_state(struct fpga_manager *mgr)
+static int fpga_mgr_low_level_state(struct fpga_manager *mgr)
 {
 	if (!mgr || !mgr->mops || !mgr->mops->state)
 		return FPGA_MGR_STATE_UNKNOWN;
@@ -321,7 +321,7 @@ static const struct attribute_group fpga_mgr_group = {
 	.attrs = fpga_mgr_attrs,
 };
 
-const struct attribute_group *fpga_mgr_groups[] = {
+static const struct attribute_group *fpga_mgr_groups[] = {
 	&fpga_mgr_group,
 	NULL,
 };
@@ -362,7 +362,7 @@ static int fpga_mgr_resume(struct device *dev)
 	return 0;
 }
 
-const struct dev_pm_ops fpga_mgr_dev_pm_ops = {
+static const struct dev_pm_ops fpga_mgr_dev_pm_ops = {
 	.suspend	= fpga_mgr_suspend,
 	.resume		= fpga_mgr_resume,
 };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ