linux-kernel - Re: [PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Dec 2014 23:57:41 +0000
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Joe Perches <joe@...ches.com>
Cc:	m.chehab@...sung.com, jarod@...sonet.com,
	gregkh@...uxfoundation.org, mahfouz.saif.elyazal@...il.com,
	gulsah.1004@...il.com, tuomas.tynkkynen@....fi,
	linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted
 strings split across lines

On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote:
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle recommends not splitting quotes strings across lines
> > because it breaks the ability to grep for the string. Fixing these.
> []
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> []
> > @@ -794,9 +796,9 @@ static int fw_load(struct IR_tx *tx)
> >  	if (!read_uint8(&data, tx_data->endp, &version))
> >  		goto corrupt;
> >  	if (version != 1) {
> > -		dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected"
> > -			    "1) -- please upgrade to a newer driver",
> > -			    version);
> > +		dev_err(tx->ir->l.dev,
> > +			"unsupported code set file version (%u, expected 1) -- please upgrade to a newer driver",
> > +			version);
> 
> Unrelated but this one should have a '\n' termination
> at the end of the format.
> 

I can add that change, no problem. As part of this patch or a third one?

Thanks for reviewing,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/