linux-kernel - Re: Re: [PATCH] USB: serial: add nt124 usb to serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Dec 2014 09:05:30 -0000
From:	Karl Palsson <karlp@...ak.net.au>
To:	"Johan Hovold" <johan@...nel.org>
Cc:	"George McCollister" <george.mccollister@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: Re: [PATCH] USB: serial: add nt124 usb to serial driver


Johan Hovold <johan@...nel.org> wrote:
> On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:

> > +	newline.bParityType = termios->c_cflag & PARENB ?
> > +				(termios->c_cflag & PARODD ? 1 : 2) +
> > +				(termios->c_cflag & CMSPAR ? 2 : 0) : 0;
> 
> This hardly readable. Don't use ?:
> 

There's also C_PARENB(tty),  C_PARODD(tty), and C_CMSPAR(tty) macros
available, in addition to the others that Johan pointed out.

Sincerely,
Karl P