linux-kernel - Re: randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Dec 2014 14:22:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jim.epost@...il.com
Cc:	sfr@...b.auug.org.au, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, f.fainelli@...il.com,
	netdev@...r.kernel.org
Subject: Re: randconfig build error with next-20141210, in
 drivers/net/ethernet/broadcom/genet

From: Jim Davis <jim.epost@...il.com>
Date: Wed, 10 Dec 2014 09:10:45 -0700

> Building with the attached random configuration file,
> 
> ERROR: "fixed_phy_register"
> [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!

Florian, I don't understand why FIXED_PHY is only selected in Kconfig
if the driver is statically built into the kernel.

That makes no sense at all, you should need that module regardless of
how the driver itself is enabled.

Can't we just remove the "XXX=y" in all of those silly:

	select FIXED_PHY if XXX=y

expressions?

There are three such cases right now:

drivers/net/dsa/Kconfig:	select FIXED_PHY if NET_DSA_BCM_SF2=y
drivers/net/ethernet/broadcom/Kconfig:	select FIXED_PHY if BCMGENET=y
drivers/net/ethernet/broadcom/Kconfig:	select FIXED_PHY if SYSTEMPORT=y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/