linux-kernel - Re: [PATCH v2 3/5] rc: img-ir: biphase enabled with workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2014 13:55:33 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	<mchehab@....samsung.com>
CC:	Sifan Naeem <sifan.naeem@...tec.com>,
	<linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
	<james.hartley@...tec.com>, <ezequiel.garcia@...tec.com>
Subject: Re: [PATCH v2 3/5] rc: img-ir: biphase enabled with workaround

On 12/12/14 12:07, James Hogan wrote:
> Hi Sifan,
> 
> On 11/12/14 20:06, Sifan Naeem wrote:
>> Biphase decoding in the current img-ir has got a quirk, where multiple
>> Interrupts are generated when an incomplete IR code is received by the
>> decoder.
>>
>> Patch adds a work around for the quirk and enables biphase decoding.
>>
>> Changes from v1:
>>  * rebased due to conflict with "img-ir/hw: Fix potential deadlock stopping timer"
>>  * spinlock taken in img_ir_suspend_timer
>>  * check for hw->stopping before handling quirks in img_ir_isr_hw
>>  * new memeber added to img_ir_priv_hw to save irq status over suspend
> 
> For future reference, the list of changes between patchset versions is
> usually put after a "---" so that it doesn't get included in the final
> git commit message. You can also add any Acked-by/Reviewed-by tags
> you've been given to new versions of patchset, assuming nothing
> significant has changed in that patch (maintainers generally add
> relevant tags for you, that are sent in response to the patches being
> applied).
> 
> Anyway, the whole patchset looks okay to me, aside from the one question
> I just asked on patch 3 of v1, which I'm not so sure about. I'll let you
> decide whether that needs changing since you have the hardware to verify it.
> 
> So for the whole patchset feel free to add my:
> Acked-by: James Hogan <james.hogan@...tec.com>

Mauro: Assuming no other changes are requested in this patchset, do you
want these resent with the moving of changelogs out of the main commit
messages?

Cheers
James


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)