[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 12 Dec 2014 09:31:57 -0600
From: atull <atull@...nsource.altera.com>
To: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
CC: kbuild test robot <fengguang.wu@...el.com>, <kbuild-all@...org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
<devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can
be static
On Thu, 11 Dec 2014, One Thousand Gnomes wrote:
> On Thu, 11 Dec 2014 09:43:24 +0800
> kbuild test robot <fengguang.wu@...el.com> wrote:
>
> > drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>
> Ought to be const as well by the look of it - we don't want function
> pointers in patchable memory spaces.
>
I agree. Will be in v5.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists