linux-kernel - Re: [GIT PULL] Btrfs for 3.19-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2014 14:33:00 -0500
From:	Chris Mason <clm@...com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-btrfs <linux-btrfs@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Btrfs for 3.19-rc



On Fri, Dec 12, 2014 at 2:24 PM, Linus Torvalds 
<torvalds@...ux-foundation.org> wrote:
> On Fri, Dec 12, 2014 at 11:07 AM, Chris Mason <clm@...com> wrote:
>> 
>>  From a feature point of view, most of the code here comes from Miao 
>> Xie
>>  and others at Fujitsu to implement scrubbing and replacing devices 
>> on
>>  raid56.  This has been in development for a while, and it's a big
>>  improvement.
> 
> So this has probably happened before, and I just haven't been looking,
> but I thought I'd mention it.
> 
> There are merges from github for this feature, and those merges aren't
> signed, and don't have merge messages. Maybe you actually verified all
> of it other ways, but there's no sign of it. I generally push back on
> merging unsigned stuff from random hosting places (to the point where
> I just refuse to do it, although it's possible that some pass though
> just due to inattention), and I think that's just good practice in
> general. And merges that don't explain what the merge does are just
> bad merges (they are extra annoying when they are back-merges, but
> it's a problem even otherwise).

Thanks, in this case he also posted the patches to the btrfs list.  
Using git pull is easier for all the obvious reasons, so I took the 
github tree.  It definitely looked right to me, but I'll compare the 
github code with his patches directly on top of rc6.

Next time I'll make sure they are signed though.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/