[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 12 Dec 2014 22:27:27 +0100
From: Jan Kara <jack@...e.cz>
To: Jiri Slaby <jslaby@...e.cz>
Cc: reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
Jan Kara <jack@...e.cz>, All Versions <stable@...r.kernel.org>
Subject: Re: [PATCH 1/1] reiserfs: destroy allocated commit workqueue
On Fri 12-12-14 16:29:29, Jiri Slaby wrote:
> When resirefs is trying to mount a partition, it creates a commit
> workqueue (sbi->commit_wq). But when mount fails later, the workqueue
> is not freed.
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Reported-by: auxsvr@...il.com
> Reported-by: BenoƮt Monin <benoit.monin@....fr>
> Cc: Jan Kara <jack@...e.cz>
> Cc: All Versions <stable@...r.kernel.org>
> Cc: reiserfs-devel@...r.kernel.org
Thanks, I've added the patch to my tree and will send it to Linus soon.
Honza
> ---
> fs/reiserfs/super.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index ea63ab13ef92..71fbbe3e2dab 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -2172,6 +2172,9 @@ error_unlocked:
> reiserfs_write_unlock(s);
> }
>
> + if (sbi->commit_wq)
> + destroy_workqueue(sbi->commit_wq);
> +
> cancel_delayed_work_sync(&REISERFS_SB(s)->old_work);
>
> reiserfs_free_bitmap_cache(s);
> --
> 2.2.0
>
--
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists