lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Dec 2014 03:14:29 +0000 From: Al Viro <viro@...IV.linux.org.uk> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Dave Jones <davej@...hat.com>, Chris Mason <clm@...com>, Mike Galbraith <umgwanakikbuti@...il.com>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Dâniel Fraga <fragabr@...il.com>, Sasha Levin <sasha.levin@...cle.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: frequent lockups in 3.18rc4 On Sat, Dec 13, 2014 at 05:35:17PM -0800, Linus Torvalds wrote: > On Sat, Dec 13, 2014 at 4:33 PM, Al Viro <viro@...iv.linux.org.uk> wrote: > > > > So does SMP - this_cpu_dec() relies on preemption being disabled. > > No. really. It very much does not. Not on x86, not elsewhere. It's > part of the whole point of "this_cpu_p()". They are preemption and > interrupt safe. > > It's the "__this_cpu_op()" ones that need external protection. Right you are - I really need to get some coffee... Sorry... FWIW, do we need to disable interrupts there? After all, mnt_want_write() and mnt_drop_write() shouldn't be done from interrupt context - they can happen via schedule_delayed_work(), but that's it... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists