linux-kernel - Re: [v4,4/4] powernv: powerpc: Add winkle support for offline cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Dec 2014 11:01:41 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Shreyas B Prabhu <shreyas@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [v4,4/4] powernv: powerpc: Add winkle support for offline cpus

On Sun, 2014-12-14 at 17:22 +0530, Shreyas B Prabhu wrote:
> On Sunday 14 December 2014 03:35 PM, Michael Ellerman wrote:
> >> diff --git a/arch/powerpc/platforms/powernv/subcore.h b/arch/powerpc/platforms/powernv/subcore.h
> >> index 148abc9..604eb40 100644
> >> --- a/arch/powerpc/platforms/powernv/subcore.h
> >> +++ b/arch/powerpc/platforms/powernv/subcore.h
> >> @@ -15,4 +15,5 @@
> >>  
> >>  #ifndef __ASSEMBLY__
> >>  void split_core_secondary_loop(u8 *state);
> >> +extern void update_subcore_sibling_mask(void);
> >>  #endif
> > 
> > subcore.c isn't built for CONFIG_SMP=n, resulting in:
> > 
> >   setup.c:(.init.text+0x34b0): undefined reference to `.update_subcore_sibling_mask'
> > 
> > I needed to add:
> > 
> > +#else
> > +static inline void update_subcore_sibling_mask(void) { };
> > +#endif /* CONFIG_SMP */

> Sorry I missed that.

No worries.

Can you please do a quick test with a SMP=n kernel.

It looks like it should work, but it would be good to test.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/